implement basic will_rename_files #1284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinto0
force-pushed
the
export-D84537597
branch
2 times, most recently
from
ac9951e to
2c8a65a
Compare
kinto0
added a commit
to kinto0/pyrefly
that referenced
this pull request
Oct 16, 2025
Summary: basic support for willRenameFiles. I found document_changes to be the only way that worked reliably on windows so I implemented both document_changes and changes (depending on the client capability). Differential Revision: D84537597
Summary: will_rename_files is a request that the language client sends before renaming files. pyrefly should handle this by updating imports. Reviewed By: grievejia Differential Revision: D84537595
Summary: basic support for willRenameFiles. I found document_changes to be the only way that worked reliably on windows so I implemented both document_changes and changes (depending on the client capability). Differential Revision: D84537597
kinto0
force-pushed
the
export-D84537597
branch
from
2c8a65a to
eb80d0e
Compare
connernilsen
approved these changes
Oct 20, 2025
|
This pull request has been merged in d047737. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: will_rename_files fixes imports when renaming files in the editor
Differential Revision: D84537597